-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(kuma-dp): cleanup bootstrap version field #3670
chore(kuma-dp): cleanup bootstrap version field #3670
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3670 +/- ##
==========================================
- Coverage 56.13% 56.10% -0.03%
==========================================
Files 918 918
Lines 55044 55043 -1
==========================================
- Hits 30900 30883 -17
- Misses 21694 21713 +19
+ Partials 2450 2447 -3
Continue to review full report at Codecov.
|
I think this makes sense @lobkovilya can you double check as the TODO was coming from you :) |
If I recall correctly, we didn't release Kuma with Envoy 1.20 (even though it's in master for a while). We've left this field for compatibility reasons, so new kuma-dp could request an old kuma-cp. So I think we should postpone merging this PR. |
@lobkovilya now that we are running 1.21 can we do this? Or should we wait another release? |
@tharun208 we are ready to merge it, but could you merge the newest origin/master before it? |
Fixes kumahq#2986 Signed-off-by: Tharun <rajendrantharun@live.com>
9075dc8
to
e91230c
Compare
@jakubdyszkiewicz done 👍🏻 |
@Mergifyio update |
✅ Branch has been successfully updated |
@jakubdyszkiewicz ok to merge? |
Signed-off-by: Tharun <rajendrantharun@live.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Signed-off-by: Tharun <rajendrantharun@live.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Signed-off-by: Tharun <rajendrantharun@live.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Summary
This PR deletes the
BootstrapVersion
field from BootstrapRequest.Full changelog
BootstrapVersion
fieldIssues resolved
Fix #2986
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy