Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-dp): cleanup bootstrap version field #3670

Merged

Conversation

tharun208
Copy link
Contributor

Summary

This PR deletes the BootstrapVersion field from BootstrapRequest.

Full changelog

  • Removed the BootstrapVersion field
  • Updated tests

Issues resolved

Fix #2986

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@tharun208 tharun208 requested a review from a team as a code owner January 7, 2022 17:12
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #3670 (e91230c) into master (08cde76) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3670      +/-   ##
==========================================
- Coverage   56.13%   56.10%   -0.03%     
==========================================
  Files         918      918              
  Lines       55044    55043       -1     
==========================================
- Hits        30900    30883      -17     
- Misses      21694    21713      +19     
+ Partials     2450     2447       -3     
Impacted Files Coverage Δ
...pp/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go 60.57% <ø> (-0.38%) ⬇️
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
pkg/kds/reconcile/reconciler.go 79.48% <0.00%> (-5.13%) ⬇️
...s/authn/api-server/tokens/admin_token_bootstrap.go 78.00% <0.00%> (-4.00%) ⬇️
pkg/insights/resyncer.go 71.16% <0.00%> (-2.46%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.65% <0.00%> (-1.15%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cde76...e91230c. Read the comment docs.

@lahabana
Copy link
Contributor

I think this makes sense @lobkovilya can you double check as the TODO was coming from you :)

@lobkovilya
Copy link
Contributor

If I recall correctly, we didn't release Kuma with Envoy 1.20 (even though it's in master for a while). We've left this field for compatibility reasons, so new kuma-dp could request an old kuma-cp. So I think we should postpone merging this PR.

@lahabana
Copy link
Contributor

lahabana commented Mar 2, 2022

@lobkovilya now that we are running 1.21 can we do this? Or should we wait another release?

@jakubdyszkiewicz
Copy link
Contributor

@tharun208 we are ready to merge it, but could you merge the newest origin/master before it?

Fixes kumahq#2986

Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208 tharun208 force-pushed the chore/cleanup_bootstrap_version_field branch from 9075dc8 to e91230c Compare March 7, 2022 10:18
@tharun208
Copy link
Contributor Author

@jakubdyszkiewicz done 👍🏻

@lahabana
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

update

✅ Branch has been successfully updated

@lahabana
Copy link
Contributor

@jakubdyszkiewicz ok to merge?

@jakubdyszkiewicz jakubdyszkiewicz merged commit 0230ccb into kumahq:master Mar 21, 2022
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Mar 30, 2022
Signed-off-by: Tharun <rajendrantharun@live.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Signed-off-by: Tharun <rajendrantharun@live.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Signed-off-by: Tharun <rajendrantharun@live.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete 'BootstrapVersion' field from BootstrapRequest
5 participants