-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(k8s): reconcile serviceMaps when using mesh namespace annotation #3815
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3815 +/- ##
=======================================
Coverage 55.79% 55.80%
=======================================
Files 916 916
Lines 54617 54620 +3
=======================================
+ Hits 30473 30478 +5
Misses 21701 21701
+ Partials 2443 2441 -2
Continue to review full report at Codecov.
|
ccd45f1
to
cc4e082
Compare
cc4e082
to
1aa571b
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
@Mergifyio update |
✅ Branch has been successfully updated |
We were not looking at annotations on the namespace when looking at config map that need to be reconciled when service changes. This would cause issue if pods were not individually annotated. Signed-off-by: Charly Molter <charly.molter@konghq.com>
417823c
to
36ae244
Compare
I don't think we need to look into a namespace.
|
…umahq#3815) We were not looking at annotations on the namespace when looking at config map that need to be reconciled when service changes. This would cause issue if pods were not individually annotated. Signed-off-by: Charly Molter <charly.molter@konghq.com> Signed-off-by: Sally Blich <sally.blich@walkme.com>
Summary
We were not looking at annotations on the namespace when looking
at config map that need to be reconciled when service changes.
This would cause issue if pods were not individually annotated.
Testing
Backwards compatibility
[ ] UpdateUPGRADE.md
with any steps users will need to take when upgrading.[ ] Addbackport-to-stable
label if the code follows our backporting policy