fix(*): proxyTemplate validation error #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoferrer
commented
Feb 26, 2022
marcoferrer
commented
Feb 26, 2022
marcoferrer
force-pushed
the
bugfix-invalid-proxy-template-profile
branch
from
77c0749 to
4ea5227
Compare
|
Hey, @marcoferrer thanks for the fix! It looks good, I hope in the future (maybe with #3820 ) we can have a better approach than global variables + You are right that we just recently added "dynamic" profile called Gateway. When it comes to a test, you could add a use case in or you could write E2E test for it here https://github.com/kumahq/kuma/blob/master/test/e2e/proxytemplate/proxy_template_universal.go or there https://github.com/kumahq/kuma/blob/master/test/e2e/gateway/gateway_universal.go |
michaelbeaumont
changed the title
lahabana
changed the title
michaelbeaumont
force-pushed
the
bugfix-invalid-proxy-template-profile
branch
from
4ea5227 to
5a84e79
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
bugfix-invalid-proxy-template-profile
branch
from
5a84e79 to
0e59d8b
Compare
michaelbeaumont
changed the title
Signed-off-by: marco.ferrer <marco.ferrer@reddit.com>
michaelbeaumont
force-pushed
the
bugfix-invalid-proxy-template-profile
branch
from
0e59d8b to
1b55415
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
bugfix-invalid-proxy-template-profile
branch
from
ca84939 to
1babfb7
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
bugfix-invalid-proxy-template-profile
branch
from
1babfb7 to
b3e5e54
Compare
jakubdyszkiewicz
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #3935
Not sure if tests are needed for this change or what would be the best way of going about adding them