Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kumactl): prefix MeshGatewayRoutes with ROUTE in inspect dataplane output #4077

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Mar 29, 2022

Summary

The output is otherwise confusing if the route's name doesn't make it clear it's a route.

Changelog: feat(inspect): add gateways to policy inspect

…ane output

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner March 29, 2022 16:08
@codecov-commenter
Copy link

Codecov Report

Merging #4077 (25359fe) into master (3533601) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4077      +/-   ##
==========================================
- Coverage   55.84%   55.82%   -0.02%     
==========================================
  Files         922      922              
  Lines       55451    55451              
==========================================
- Hits        30966    30958       -8     
- Misses      22034    22040       +6     
- Partials     2451     2453       +2     
Impacted Files Coverage Δ
app/kumactl/cmd/inspect/inspect_dataplane.go 61.53% <ø> (ø)
pkg/xds/cache/once/cache.go 87.17% <0.00%> (-7.70%) ⬇️
pkg/defaults/components.go 85.18% <0.00%> (-3.71%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.65% <0.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3533601...25359fe. Read the comment docs.

@michaelbeaumont michaelbeaumont changed the title chore(kumactl): prefix MeshGatewayRoutes with ROUTE in inspect datapl… chore(kumactl): prefix MeshGatewayRoutes with ROUTE in inspect dataplane output Mar 29, 2022
@michaelbeaumont michaelbeaumont merged commit 4ccf576 into kumahq:master Mar 30, 2022
@michaelbeaumont michaelbeaumont deleted the chore/inspect_gateway_route branch March 30, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants