Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(UPGRADE.md): add note about Inspect API changes #4125

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Apr 5, 2022

Summary

Technically a breaking change... do we think it's worth mentioning?

Changelog: feat(inspect): add gateways to policy inspect

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner April 5, 2022 12:31
@codecov-commenter
Copy link

Codecov Report

Merging #4125 (21695b6) into master (e88a16e) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4125      +/-   ##
==========================================
+ Coverage   55.72%   55.75%   +0.03%     
==========================================
  Files         932      932              
  Lines       56224    56224              
==========================================
+ Hits        31331    31350      +19     
+ Misses      22416    22394      -22     
- Partials     2477     2480       +3     
Impacted Files Coverage Δ
pkg/defaults/components.go 85.18% <0.00%> (-3.71%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.80% <0.00%> (+1.14%) ⬆️
pkg/insights/resyncer.go 74.07% <0.00%> (+2.46%) ⬆️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (+2.59%) ⬆️
pkg/kds/reconcile/reconciler.go 84.61% <0.00%> (+5.12%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/kds/client/sink.go 67.56% <0.00%> (+8.10%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88a16e...21695b6. Read the comment docs.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 2462011 into kumahq:master Apr 5, 2022
@michaelbeaumont michaelbeaumont deleted the docs/upgrade_inspect branch April 5, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants