Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dns)!: remove dns server #4192

Merged
merged 1 commit into from
Apr 29, 2022
Merged

chore(dns)!: remove dns server #4192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ does not have any particular instructions.

## Upcoming release

The `control-plane` no longer hosts a builtin DNS server. You should always rely on the embedded DNS in the dataplane proxy and VIPs can't be used without transparent proxy.

## Upgrade to `1.6.x`

### Helm
Expand Down
5 changes: 0 additions & 5 deletions app/kuma-cp/cmd/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/kumahq/kuma/pkg/core/bootstrap"
"github.com/kumahq/kuma/pkg/defaults"
"github.com/kumahq/kuma/pkg/diagnostics"
"github.com/kumahq/kuma/pkg/dns"
dp_server "github.com/kumahq/kuma/pkg/dp-server"
"github.com/kumahq/kuma/pkg/gc"
"github.com/kumahq/kuma/pkg/hds"
Expand Down Expand Up @@ -88,10 +87,6 @@ func newRunCmdWithOpts(opts kuma_cmd.RunCmdOpts) *cobra.Command {
runLog.Error(err, "unable to set up Monitoring Assignment server")
return err
}
if err := dns.Setup(rt); err != nil {
runLog.Error(err, "unable to set up DNS")
return err
}
if err := xds.Setup(rt); err != nil {
runLog.Error(err, "unable to set up XDS")
return err
Expand Down
36 changes: 0 additions & 36 deletions app/kumactl/cmd/completion/testdata/bash.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3679,41 +3679,6 @@ _kumactl_install_demo()
noun_aliases=()
}

_kumactl_install_dns()
{
last_command="kumactl_install_dns"

command_aliases=()

commands=()

flags=()
two_word_flags=()
local_nonpersistent_flags=()
flags_with_completion=()
flags_completion=()

flags+=("--namespace=")
two_word_flags+=("--namespace")
local_nonpersistent_flags+=("--namespace")
local_nonpersistent_flags+=("--namespace=")
flags+=("--port=")
two_word_flags+=("--port")
local_nonpersistent_flags+=("--port")
local_nonpersistent_flags+=("--port=")
flags+=("--api-timeout=")
two_word_flags+=("--api-timeout")
flags+=("--config-file=")
two_word_flags+=("--config-file")
flags+=("--log-level=")
two_word_flags+=("--log-level")
flags+=("--no-config")

must_have_one_flag=()
must_have_one_noun=()
noun_aliases=()
}

_kumactl_install_gateway_kong()
{
last_command="kumactl_install_gateway_kong"
Expand Down Expand Up @@ -4017,7 +3982,6 @@ _kumactl_install()
commands+=("control-plane")
commands+=("crds")
commands+=("demo")
commands+=("dns")
commands+=("gateway")
commands+=("logging")
commands+=("metrics")
Expand Down
1 change: 0 additions & 1 deletion app/kumactl/cmd/install/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ func NewInstallCmd(pctx *kumactl_cmd.RootContext) *cobra.Command {
cmd.AddCommand(newInstallCrdsCmd(&pctx.InstallCRDContext))
cmd.AddCommand(newInstallMetrics(pctx))
cmd.AddCommand(newInstallTracing(pctx))
cmd.AddCommand(newInstallDNS())
cmd.AddCommand(newInstallLogging(pctx))
cmd.AddCommand(newInstallDemoCmd(&pctx.InstallDemoContext))
cmd.AddCommand(newInstallGatewayCmd(pctx))
Expand Down
190 changes: 0 additions & 190 deletions app/kumactl/cmd/install/install_dns.go
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,8 +1841,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,8 +1666,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,8 +1666,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.overrides.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,8 +2090,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,8 +1695,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,8 +1732,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,8 +1666,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1703,8 +1703,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
2 changes: 0 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1674,8 +1674,6 @@ spec:
- containerPort: 5682
- containerPort: 5443
- containerPort: 5678
- containerPort: 5653
protocol: UDP
livenessProbe:
httpGet:
path: /healthy
Expand Down
4 changes: 1 addition & 3 deletions deployments/charts/kuma/templates/cp-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ spec:
- containerPort: 5443
{{- if ne .Values.controlPlane.mode "global" }}
- containerPort: 5678
- containerPort: 5653
protocol: UDP
{{- end }}
{{- end }}
livenessProbe:
httpGet:
path: /healthy
Expand Down
25 changes: 0 additions & 25 deletions docs/cmd/kuma-cp/kuma-cp.md
View file
Open in desktop

This file was deleted.

Loading