Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): support ARM Linux/Darwin for dev/tools #4199

Merged
merged 11 commits into from
Apr 20, 2022
Merged

feat(*): support ARM Linux/Darwin for dev/tools #4199

merged 11 commits into from
Apr 20, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Apr 19, 2022 •
edited
Loading

Summary

Make file changes that are going to unlock migration to ARM Linux/Darwin development.

Full changelog

  • [Install etcd with specified version working on arm]
  • [Set arch type of protoc and helm for arm]
  • [use x86_64 version of shellcheck which works on M1]
  • [install kube-apiserver in the same version that comes from kubebuilder if there is no binary in kubebuilder package]

Issues resolved

Part of #237

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@lukidzi
chore(*): upgrade etcd with arm support, install independently
e7ec56f 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner April 19, 2022 16:18
lukidzi added 5 commits April 19, 2022 12:10
@lukidzi
feat(*): support protoc download for darwin arm
a2541a8 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
Merge branch 'feat/protoc_darwin' into chore/etcd
bb96888
@lukidzi
feat(*): parametrized etcd arch
649a630 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
feat(*): added goarch to be accessable
577676e 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
feat(*): update script to support shellcheck on M1
a7b601e 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi changed the title chore(*): upgrade etcd with arm support, install independently feat(*): support ARM Linux/Darwin for dev/tools Apr 19, 2022
@lukidzi
feat(*): support kubebuilder installation on arm darwin
b4e274a 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #4199 (9b897a6) into master (8135fdb) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4199      +/-   ##
==========================================
- Coverage   55.84%   55.81%   -0.04%     
==========================================
  Files         931      931              
  Lines       56485    56485              
==========================================
- Hits        31545    31527      -18     
- Misses      22421    22442      +21     
+ Partials     2519     2516       -3
Impacted Files Coverage Δ
pkg/insights/components.go 58.33% <0.00%> (-25.01%) ⬇️
pkg/core/resources/store/customizable_store.go 55.55% <0.00%> (-22.23%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
...s/authn/api-server/tokens/admin_token_bootstrap.go 78.00% <0.00%> (-4.00%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
pkg/insights/resyncer.go 71.60% <0.00%> (-2.47%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.80% <0.00%> (+1.14%) ⬆️
pkg/dns/vips_allocator.go 70.98% <0.00%> (+1.23%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8135fdb...9b897a6. Read the comment docs.

@lukidzi
feat(*): added option to install kube-apiserver when kubebuilder is m…
0accadb 
…issing it

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
feat(*): removed white line
e81e631 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

mk/dev.mk Outdated Show resolved Hide resolved
lobkovilya
lobkovilya approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome!

lukidzi added 2 commits April 20, 2022 06:50
@lukidzi
feat(*): fixed typo
9b897a6 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
Merge branch 'master' into chore/etcd
9e53caf
@lukidzi lukidzi merged commit f7e30f2 into master Apr 20, 2022
@lukidzi lukidzi deleted the chore/etcd branch April 20, 2022 13:14
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 21, 2022
@lukidzi @SallyBlichWalkMe
feat(*): support ARM Linux/Darwin for dev/tools (kumahq#4199)
44b9ea8 
added support for dev/tools installation on arm linux/osx. Separate installation of etcd which works on osx, kube-apiserver which is not always included in kubebuilder package. Shellcheck is installed in a version that works on both ends. protoc and helm also come with version that works on both arch.

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
lukidzi added a commit that referenced this pull request May 11, 2022
@lukidzi
feat(*): support ARM Linux/Darwin for dev/tools (#4199)
3466a19 
added support for dev/tools installation on arm linux/osx. Separate installation of etcd which works on osx, kube-apiserver which is not always included in kubebuilder package. Shellcheck is installed in a version that works on both ends. protoc and helm also come with version that works on both arch.

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukidzi @codecov-commenter @jakubdyszkiewicz @lobkovilya