feat(kuma-cp) - set host network var #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally Blich <sally.blich@walkme.com>
|
@jakubdyszkiewicz @lahabana |
|
Not sure why CI is not running, but I can already tell that you will need to update goldenfiles |
Thanks for the help, So I ran it again, |
|
You need to use the latest tools. You can do so with: We need to make a better job of the dev env with tools... |
Thanks for the response, |
|
Sorry need to also delete helm-docs: |
And I got the same error message at last time |
|
My bad forgot you were adding an helm config in which case the change added in the I've just tried myself and if you do: And then commit whatever changed you should be good to go |
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
Signed-off-by: Sally Blich <sally.blich@walkme.com>
lahabana
requested changes
Apr 26, 2022
app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml
Outdated
Show resolved
Hide resolved
Added all changes that were made by make test command, to update the golden files Signed-off-by: Sally Blich <sally.blich@walkme.com>
Codecov Report
@@ Coverage Diff @@
## master #4209 +/- ##
==========================================
- Coverage 55.68% 55.68% -0.01%
==========================================
Files 939 939
Lines 56691 56691
==========================================
- Hits 31569 31567 -2
- Misses 22607 22608 +1
- Partials 2515 2516 +1
Continue to review full report at Codecov.
|
lahabana
approved these changes
Apr 28, 2022
parkanzky
pushed a commit
that referenced
this pull request
May 6, 2022
For alternate overlay networking(other than the basic CNI provided by EKS for example, like cilium), This is mandatory value that has to be set, otherwise it will have communication errors with the control plane. If you are using the default CNI component, it's running on the default network. Implement hostNetwork: true in cp-deployment.yaml file. Signed-off-by: Sally Blich <sally.blich@walkme.com> Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
lukidzi
pushed a commit
that referenced
this pull request
May 11, 2022
For alternate overlay networking(other than the basic CNI provided by EKS for example, like cilium), This is mandatory value that has to be set, otherwise it will have communication errors with the control plane. If you are using the default CNI component, it's running on the default network. Implement hostNetwork: true in cp-deployment.yaml file. Signed-off-by: Sally Blich <sally.blich@walkme.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For alternate overlay networking(other than the basic CNI provided by EKS for example, like cilium),
This is mandatory value that has to be set, otherwise it will have communication errors with the control plane.
If you are using the default CNI component, it's running on the default network.
Documentation
Testing
Backwards compatibility
UPGRADE.mdwith any steps users will need to take when upgrading.backport-to-stablelabel if the code follows our backporting policy