Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatically detect dns lookup family for cp cluster #4275

Conversation

slonka
Copy link
Contributor

@slonka slonka commented May 12, 2022

Signed-off-by: slonka slonka@users.noreply.github.com

Summary

An alternative to #4264. Instead of allowing the user to configure DnsLooupFamily we run a query in kuma-dp and determine it ourselves.

Full changelog

  • Implement dnsLookupFamilyFromXdsHost which looks up XdsHost IPs and sets DnsLooupFamily accordingly

Issues resolved

Fix #2000

Documentation

  • No additional docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • No breaking changes
  • doesn't meet backporting criteria

slonka added 2 commits May 12, 2022 16:52
Signed-off-by: slonka <slonka@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #4275 (df367b6) into master (1f12a16) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4275      +/-   ##
==========================================
+ Coverage   55.34%   55.41%   +0.07%     
==========================================
  Files         941      941              
  Lines       57087    57101      +14     
==========================================
+ Hits        31593    31643      +50     
+ Misses      22975    22953      -22     
+ Partials     2519     2505      -14     
Impacted Files Coverage Δ
pkg/xds/bootstrap/template_v3.go 99.21% <100.00%> (+0.04%) ⬆️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.80% <0.00%> (+1.14%) ⬆️
pkg/plugins/resources/postgres/store.go 76.37% <0.00%> (+1.68%) ⬆️
pkg/api-server/server.go 87.44% <0.00%> (+2.09%) ⬆️
pkg/core/secrets/manager/global_manager.go 42.42% <0.00%> (+3.03%) ⬆️
pkg/defaults/components.go 85.71% <0.00%> (+3.57%) ⬆️
...s/authn/api-server/tokens/admin_token_bootstrap.go 86.00% <0.00%> (+4.00%) ⬆️
pkg/core/tokens/signing_key_manager.go 90.00% <0.00%> (+5.00%) ⬆️
pkg/core/runtime/component/component.go 93.54% <0.00%> (+9.67%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f12a16...df367b6. Read the comment docs.

Signed-off-by: slonka <slonka@users.noreply.github.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx for finding a way to get rid of the parameter

pkg/xds/bootstrap/template_v3.go Show resolved Hide resolved
pkg/xds/bootstrap/export_template.go Outdated Show resolved Hide resolved
bartsmykla and others added 6 commits May 23, 2022 10:24
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review May 23, 2022 12:05
@slonka slonka requested a review from a team as a code owner May 23, 2022 12:05
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka merged commit 3bbe39e into master May 23, 2022
@slonka slonka deleted the fix/automatically-set-dns-lookup-family-for-ads-cluster-of-xds-host branch May 23, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ads_cluster + STRICT_DNS tries to resolve IPV6 addr
6 participants