-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: automatically detect dns lookup family for cp cluster #4275
fix: automatically detect dns lookup family for cp cluster #4275
Conversation
Signed-off-by: slonka <slonka@users.noreply.github.com>
…r-ads-cluster-of-xds-host
Codecov Report
@@ Coverage Diff @@
## master #4275 +/- ##
==========================================
+ Coverage 55.34% 55.41% +0.07%
==========================================
Files 941 941
Lines 57087 57101 +14
==========================================
+ Hits 31593 31643 +50
+ Misses 22975 22953 -22
+ Partials 2519 2505 -14
Continue to review full report at Codecov.
|
Signed-off-by: slonka <slonka@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thx for finding a way to get rid of the parameter
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
…r-ads-cluster-of-xds-host
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
…r-ads-cluster-of-xds-host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka slonka@users.noreply.github.com
Summary
An alternative to #4264. Instead of allowing the user to configure DnsLooupFamily we run a query in kuma-dp and determine it ourselves.
Full changelog
dnsLookupFamilyFromXdsHost
which looks upXdsHost
IPs and setsDnsLooupFamily
accordinglyIssues resolved
Fix #2000
Documentation
Testing
Backwards compatibility