Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): add loadBalancerIP to MeshGatewayInstance #4519

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

michaelbeaumont
Copy link
Contributor

Summary

As discussed in #4075 (comment), this is necessary for Azure Load Balancers with static IPs.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner June 29, 2022 12:23
@michaelbeaumont michaelbeaumont marked this pull request as draft June 29, 2022 13:26
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review July 4, 2022 13:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #4519 (5f178a7) into master (cb04bdd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4519      +/-   ##
==========================================
- Coverage   47.06%   47.05%   -0.02%     
==========================================
  Files         676      676              
  Lines       45064    45075      +11     
==========================================
- Hits        21210    21208       -2     
- Misses      21992    22006      +14     
+ Partials     1862     1861       -1     
Impacted Files Coverage Δ
...s/k8s/native/api/v1alpha1/zz_generated.deepcopy.go 30.78% <0.00%> (-0.24%) ⬇️
...ime/k8s/controllers/gateway_instance_controller.go 0.00% <0.00%> (ø)
pkg/api-server/server.go 74.58% <0.00%> (-2.09%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 89.36% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb04bdd...5f178a7. Read the comment docs.

@michaelbeaumont michaelbeaumont merged commit 8f5d8d7 into kumahq:master Jul 6, 2022
@michaelbeaumont michaelbeaumont deleted the feat/gateway_lbip branch July 6, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants