Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): use remote address for Gateway #4530

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jun 30, 2022

Summary

Use remote address for incoming connections to Gateway.

Issues resolved

Fix #4506

Documentation

- [ ] Link to the website documentation PR

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review June 30, 2022 14:48
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner June 30, 2022 14:48
@jakubdyszkiewicz jakubdyszkiewicz merged commit 982c910 into master Jul 1, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/gateway-useremoteaddress branch July 1, 2022 08:41
mergify bot pushed a commit that referenced this pull request Jul 1, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 982c910)

# Conflicts:
#	pkg/plugins/runtime/gateway/testdata/http/cross-mesh-gateway.yaml
#	pkg/plugins/runtime/gateway/testdata/https/cross-mesh-gateway.yaml
jakubdyszkiewicz added a commit that referenced this pull request Jul 1, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
mergify bot added a commit that referenced this pull request Jul 1, 2022
feat(kuma-cp): use remote address for Gateway (#4530)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh gateway envoy config should have use_remote_address set to true
2 participants