Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gateway): npe without any timeout #4548

Merged
merged 1 commit into from
Jul 4, 2022
Merged

fix(gateway): npe without any timeout #4548

merged 1 commit into from
Jul 4, 2022

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Closes #4484

@michaelbeaumont
fix(gateway): NPE when no timeouts
ec5a86a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 4, 2022 14:29
@michaelbeaumont michaelbeaumont changed the title fix(gateway): NPE without any timeout fix(gateway): npe without any timeout Jul 4, 2022
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 4, 2022 14:32
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to also include a test if possible.

@michaelbeaumont michaelbeaumont merged commit f24fdb1 into kumahq:master Jul 4, 2022
@michaelbeaumont michaelbeaumont deleted the fix/gateway_cluster_npe branch July 4, 2022 15:29
mergify bot pushed a commit that referenced this pull request Jul 4, 2022
@michaelbeaumont @mergify
fix(gateway): npe without any timeout (#4548)
599ac9f 
fix(gateway): NPE when no timeouts

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit f24fdb1)
@mergify mergify bot mentioned this pull request Jul 4, 2022
Merged
mergify bot added a commit that referenced this pull request Jul 4, 2022
@mergify @michaelbeaumont
fix(gateway): npe without any timeout (backport #4548) (#4550)
d98a6a0 
fix(gateway): npe without any timeout (#4548)

fix(gateway): NPE when no timeouts

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit f24fdb1)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CP fails to generate gateway cluster if no Timeout policy is defined for the destination
2 participants
@michaelbeaumont @jakubdyszkiewicz