Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demo): update demo to latest version #4572

Merged
merged 2 commits into from
Jul 11, 2022
Merged

chore(demo): update demo to latest version #4572

merged 2 commits into from
Jul 11, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jul 8, 2022 •
edited
Loading

  • add make dev/sync-demo to download the latest version of the demo

Fix #4558

Signed-off-by: Charly Molter charly.molter@konghq.com

@lahabana lahabana requested a review from a team as a code owner July 8, 2022 12:38
@lahabana
chore(demo): update demo to latest version
53357f3 
- add `make dev/sync-demo` to download the latest version of the demo

Fix kumahq#4558

Signed-off-by: Charly Molter <charly.molter@konghq.com>
michaelbeaumont
michaelbeaumont approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lahabana lahabana enabled auto-merge (squash) July 8, 2022 12:55
@lahabana
Copy link
Contributor Author

/golden_files

@lahabana lahabana disabled auto-merge July 11, 2022 07:11
@github-actions
fix(ci): format files
5bb5f2b 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #4572 (5bb5f2b) into master (47498b7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4572   +/-   ##
=======================================
  Coverage   47.07%   47.07%           
=======================================
  Files         677      677           
  Lines       45171    45171           
=======================================
+ Hits        21263    21264    +1     
+ Misses      22040    22039    -1     
  Partials     1868     1868
Impacted Files Coverage Δ
pkg/plugins/leader/postgres/leader_elector.go 82.97% <0.00%> (-6.39%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47498b7...5bb5f2b. Read the comment docs.

@lahabana lahabana enabled auto-merge (squash) July 11, 2022 08:09
@lahabana lahabana merged commit 222ad29 into kumahq:master Jul 11, 2022
mergify bot pushed a commit that referenced this pull request Jul 11, 2022
@lahabana @mergify
chore(demo): update demo to latest version (#4572)
0fc3276 
- add `make dev/sync-demo` to download the latest version of the demo

Fix #4558

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 222ad29)
@mergify mergify bot mentioned this pull request Jul 11, 2022
Merged
jakubdyszkiewicz pushed a commit that referenced this pull request Jul 13, 2022
@lahabana @mergify
chore(demo): update demo to latest version (#4572)
f3eb295 
- add `make dev/sync-demo` to download the latest version of the demo

Fix #4558

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 222ad29)
mergify bot added a commit that referenced this pull request Jul 13, 2022
@mergify @lahabana
chore(demo): update demo to latest version (backport #4572) (#4587)
3856064 
chore(demo): update demo to latest version (#4572)

- add `make dev/sync-demo` to download the latest version of the demo

Fix #4558

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 222ad29)

Co-authored-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana deleted the updateDemo branch March 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kumactl installs NOT multiarch demo
5 participants
@lahabana @codecov-commenter @michaelbeaumont @jakubdyszkiewicz @lukidzi