chore(kuma-dp): remove envoy admin port flag

[tharun208]

Summary

remove deprecated admin-port command-line argument from kuma-dp

Full changelog

• remove admin port config from kuma-cp and kubernetes side-car container
• removed deprecate messages and deleted files
• updated tests

Issues resolved

Fix #4002

Documentation

• Link to the website documentation PR

Testing

• Unit tests
• E2E tests
• Manual testing on Universal
• Manual testing on Kubernetes

Backwards compatibility

• Update UPGRADE.md with any steps users will need to take when upgrading.
• Add backport-to-stable label if the code follows our backporting policy

[codecov-commenter]

Codecov Report

Merging #4574 (0c0623e) into master (b5ef221) will decrease coverage by 0.03%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #4574      +/-   ##
==========================================
- Coverage   47.05%   47.02%   -0.04%     
==========================================
  Files         677      675       -2     
  Lines       45176    45137      -39     
==========================================
- Hits        21258    21225      -33     
  Misses      22049    22049              
+ Partials     1869     1863       -6     

Impacted Files	Coverage Δ
app/kuma-cp/cmd/run.go	29.41% <ø> (-0.83%)	⬇️
app/kuma-dp/cmd/run.go	62.24% <ø> (-5.56%)	⬇️
pkg/config/app/kuma-cp/config.go	39.45% <0.00%> (-1.11%)	⬇️
pkg/config/app/kuma-dp/config.go	60.86% <ø> (ø)
pkg/config/xds/bootstrap/config.go	46.87% <ø> (ø)
...pp/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go	63.79% <100.00%> (-0.31%)	⬇️
app/kuma-dp/cmd/dataplane.go	30.43% <0.00%> (-21.74%)	⬇️
pkg/core/resources/manager/cache.go	88.31% <0.00%> (+2.59%)	⬆️
pkg/xds/cache/once/once.go	100.00% <0.00%> (+5.00%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ef221...0c0623e. Read the comment docs.

[jakubdyszkiewicz]

Hey,

there seems to be a problem with a unit test.
Other than this it looks good, but I'd like @lobkovilya to also check it.

[tharun208]

@jakubdyszkiewicz taking a look...

[lobkovilya]

Also, please take a look at https://github.com/kumahq/kuma/blob/master/pkg/xds/bootstrap/generator.go#L111-L118. And I believe we can delete AdminPort from the BootstrapRequest, right?

[tharun208]

https://github.com/kumahq/kuma/blob/master/pkg/xds/bootstrap/generator.go#L111-L118

addressed 👍🏻 thank's for pointing out

[tharun208]

@lobkovilya is it good to merge?

[lobkovilya]

What about https://github.com/kumahq/kuma/blob/master/pkg/xds/bootstrap/types/bootstrap_request.go#L7? I think we don't need it

[tharun208]

What about https://github.com/kumahq/kuma/blob/master/pkg/xds/bootstrap/types/bootstrap_request.go#L7? I think we don't need it

removed

[lobkovilya]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated