Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): validate both old and new objects on Update (backport #4589) #4593

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Backport #4589

…hq#4589)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 13, 2022 11:22
@codecov-commenter
Copy link

Codecov Report

Merging #4593 (4d8f114) into release-1.6 (d8cdf27) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-1.6    #4593      +/-   ##
===============================================
- Coverage        55.78%   55.75%   -0.03%     
===============================================
  Files              932      932              
  Lines            56249    56250       +1     
===============================================
- Hits             31376    31364      -12     
- Misses           22393    22403      +10     
- Partials          2480     2483       +3     
Impacted Files Coverage Δ
pkg/api-server/resource_endpoints.go 79.88% <100.00%> (+0.11%) ⬆️
pkg/core/resources/access/admin_resource_access.go 100.00% <100.00%> (ø)
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-5.56%) ⬇️
pkg/kds/reconcile/reconciler.go 79.48% <0.00%> (-5.13%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (-5.13%) ⬇️
pkg/api-server/server.go 85.35% <0.00%> (-2.93%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 97.87% <0.00%> (-2.13%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.65% <0.00%> (-1.15%) ⬇️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cdf27...4d8f114. Read the comment docs.

@mergify mergify bot merged commit 1eceb83 into kumahq:release-1.6 Jul 13, 2022
@michaelbeaumont michaelbeaumont deleted the feat/backport_4589 branch July 13, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants