Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): support URL rewriting #4638

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 19, 2022

Summary

Closes #4179, closes #3908

Needs subsequent docs PR hint about experimental added to kumahq/kuma-website#895

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #4638 (72b245d) into master (589eb10) will decrease coverage by 0.19%.
The diff coverage is 4.22%.

@@            Coverage Diff             @@
##           master    #4638      +/-   ##
==========================================
- Coverage   46.57%   46.38%   -0.20%     
==========================================
  Files         684      684              
  Lines       46323    46522     +199     
==========================================
+ Hits        21576    21580       +4     
- Misses      22834    23028     +194     
- Partials     1913     1914       +1     
Impacted Files Coverage Δ
...plugins/runtime/gateway/gateway_route_generator.go 94.07% <0.00%> (-5.93%) ⬇️
pkg/plugins/runtime/gateway/route/table.go 100.00% <ø> (ø)
...8s/controllers/gatewayapi/http_route_conversion.go 0.00% <0.00%> (ø)
api/mesh/v1alpha1/gateway_route.pb.go 3.33% <4.13%> (+<0.01%) ⬆️
pkg/plugins/runtime/gateway/route/configurers.go 70.02% <14.28%> (-3.71%) ⬇️
...g/plugins/runtime/gateway/route_table_generator.go 81.30% <100.00%> (+0.17%) ⬆️
pkg/xds/cache/once/cache.go 82.05% <0.00%> (-12.83%) ⬇️
pkg/xds/cache/once/once.go 95.00% <0.00%> (-5.00%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589eb10...72b245d. Read the comment docs.

@michaelbeaumont michaelbeaumont marked this pull request as ready for review July 19, 2022 09:22
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 19, 2022 09:22
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_url_rewrite branch from 6f80bc3 to 47206e1 Compare July 19, 2022 09:29
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Copy link
Contributor

@lukidzi lukidzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont marked this pull request as draft July 19, 2022 10:56
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review July 19, 2022 15:13
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 19, 2022 15:34
@michaelbeaumont michaelbeaumont disabled auto-merge July 19, 2022 15:35
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 19, 2022 15:35
@michaelbeaumont michaelbeaumont merged commit fe586e6 into kumahq:master Jul 19, 2022
@michaelbeaumont michaelbeaumont deleted the feat/gateway_url_rewrite branch July 19, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support some Gateway API experimental features Support urlRewrite in MeshGatewayRoute
4 participants