Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(xds): don't set deprecated dns_resolver_config #4702

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to docs PR or issue -- none
  • Link to UI issue or PR -- none
  • Is the issue worked on linked? -- none
  • Unit Tests -- none
  • E2E Tests -- none
  • Manual Universal Tests -- none
  • Manual Kubernetes Tests -- none
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? -- no

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 29, 2022 14:29
@michaelbeaumont michaelbeaumont force-pushed the chore/rm_dns_resolver_config branch from 1b04536 to 7997280 Compare July 29, 2022 14:40
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the chore/rm_dns_resolver_config branch from 7997280 to f0b453b Compare July 29, 2022 15:03
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 29, 2022 15:17
@codecov-commenter
Copy link

Codecov Report

Merging #4702 (f0b453b) into master (d841111) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4702   +/-   ##
=======================================
  Coverage   46.42%   46.43%           
=======================================
  Files         687      687           
  Lines       46692    46695    +3     
=======================================
+ Hits        21677    21683    +6     
+ Misses      23094    23092    -2     
+ Partials     1921     1920    -1     
Impacted Files Coverage Δ
pkg/xds/envoy/listeners/v3/dns_configurer.go 94.33% <100.00%> (+0.16%) ⬆️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (ø)
pkg/plugins/leader/postgres/leader_elector.go 89.36% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d841111...f0b453b. Read the comment docs.

@michaelbeaumont michaelbeaumont merged commit fb4dd71 into kumahq:master Aug 1, 2022
@michaelbeaumont michaelbeaumont deleted the chore/rm_dns_resolver_config branch August 1, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants