Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump google.golang.org/protobuf from 1.28.0 to 1.28.1 #4718

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2022

Bumps google.golang.org/protobuf from 1.28.0 to 1.28.1.

Release notes

Sourced from google.golang.org/protobuf's releases.

v1.28.1

This release contains protoc-gen-go binaries for arm64.

Notable changes since v1.28.0:

  • CL/418677: internal/impl: improve MessageInfo.New performance
  • CL/411377: proto: short-circuit Equal when inputs are identical
  • CL/419714: all: Add prebuild binaries for arm64
Commits
  • 6875c3d all: release v1.28.1
  • 881da6e all: Add prebuild binaries for arm64
  • 2a74a0e A+C: delete AUTHORS and CONTRIBUTORS
  • de9682a internal/impl: improve MessageInfo.New performance
  • b0a9446 all: reformat with go1.19 gofmt
  • c1bbc5d all: make integration test work on darwin/arm64
  • 5f429f7 proto: fix compilation failure in tests
  • fc44d00 proto: use reflect.Ptr for backward compatibility
  • 380c339 proto: short-circuit Equal when inputs are identical
  • 784c482 all: remove shorthand import aliases
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.28.0 to 1.28.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash)
- [Commits](protocolbuffers/protobuf-go@v1.28.0...v1.28.1)

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner August 1, 2022 15:04
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 1, 2022
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) August 1, 2022 15:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #4718 (258db06) into master (604e30f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4718   +/-   ##
=======================================
  Coverage   46.49%   46.49%           
=======================================
  Files         689      689           
  Lines       46792    46792           
=======================================
+ Hits        21756    21757    +1     
+ Misses      23109    23108    -1     
  Partials     1927     1927           
Impacted Files Coverage Δ
pkg/xds/generator/direct_access_proxy_generator.go 89.77% <0.00%> (-1.14%) ⬇️
pkg/defaults/components.go 56.66% <0.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@michaelbeaumont
Copy link
Contributor

Hmm I think this upgrade changes the generated code somehow and tests are failing.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Copy link
Contributor

@lahabana I switched to using go-cmp with proto.Equal for these comparisons since there's a bunch of hidden state otherwise. Does that make sense?

@michaelbeaumont michaelbeaumont merged commit 012b192 into master Aug 3, 2022
@michaelbeaumont michaelbeaumont deleted the dependabot/go_modules/google.golang.org/protobuf-1.28.1 branch August 3, 2022 10:19
@michaelbeaumont
Copy link
Contributor

@lahabana :what: I think I misclicked here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants