Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): check if kuma annotation or label is set but ignore value #4731

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Aug 2, 2022

Summery

Removed check if the value of annotation kuma.io/sidecar-injection is enabled, now we check if the annotation is present.

lukidzi added 2 commits August 2, 2022 12:04
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner August 2, 2022 10:54
@jakubdyszkiewicz
Copy link
Contributor

Should we document this somehow? https://kuma.io/docs/1.7.x/networking/cni/#kuma-cni

@lukidzi
Copy link
Contributor Author

lukidzi commented Aug 3, 2022

Should we document this somehow? https://kuma.io/docs/1.7.x/networking/cni/#kuma-cni

I'll add a note about this

Edit:
added kumahq/kuma-website#940

@lukidzi lukidzi merged commit ad3258f into kumahq:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With CNI, the network-attachment-definition is only created when the kuma annotations are on the namespace
3 participants