Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(kumactl): remove old flags in install tp #4760

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Aug 3, 2022

  • hide ebpf flags until we properly announce it
  • deprecate --kuma-cp-ip and --skip-resolv-conf, these
    were left overs from a time where cp would run a DNS server
    this is not the case anymore and embedded DNS works much better

Ref #4759

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue -- Need to clean reference to the flags
  • Link to UI issue or PR -- NA
  • Is the issue worked on linked? --
  • Unit Tests -- Updated golden files
  • E2E Tests -- NA
  • Manual Universal Tests -- NA
  • Manual Kubernetes Tests -- NA
  • Do you need to update UPGRADE.md? -- No
  • Does it need to be backported according to the backporting policy? -- No

@lahabana lahabana requested a review from a team as a code owner August 3, 2022 16:07
- hide ebpf flags until we properly announce it
- deprecate --kuma-cp-ip and --skip-resolv-conf, these
were left overs from a time where cp would run a DNS server
this is not the case anymore and embedded DNS works much better

Ref kumahq#4759

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana force-pushed the oldTransparentProxyFlags branch from 235cb0b to 493681a Compare August 3, 2022 16:17
@lahabana
Copy link
Contributor Author

lahabana commented Aug 3, 2022

@bartsmykla the cleanup we've talked about

@codecov-commenter
Copy link

Codecov Report

Merging #4760 (493681a) into master (c3cf155) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4760      +/-   ##
==========================================
+ Coverage   46.49%   46.50%   +0.01%     
==========================================
  Files         689      689              
  Lines       46790    46765      -25     
==========================================
- Hits        21753    21750       -3     
+ Misses      23110    23093      -17     
+ Partials     1927     1922       -5     
Impacted Files Coverage Δ
pkg/transparentproxy/kubernetes/kubernetes.go 82.47% <ø> (ø)
...p/kumactl/cmd/install/install_transparent_proxy.go 79.88% <100.00%> (+6.01%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lahabana lahabana merged commit 499f1f4 into kumahq:master Aug 4, 2022
@lahabana lahabana deleted the oldTransparentProxyFlags branch March 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants