Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): collapsed grafana dashboards #4839

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Aug 17, 2022

The change here #4727 was supposed to expand collapsed panels. However, for some reason a simple change "collapsed": true -> "collapsed": false does not fix that. The result is that all panels in this row are missing. In this PR:

  1. I reverted the changes to kuma-dataplane and kuma-service-to-service
  2. I applied all changes aside from "collapsed": true -> "collapsed": false
  3. I expanded all the panels and re-exported dashboards
  4. I replaced the dashboard with the export

Checklist prior to review

  • Link to docs PR or issue -- no
  • Link to UI issue or PR -- no
  • Is the issue worked on linked? -- Missing panes in Grafana dashboards #4832
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- no
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- we don't have e2e tests of dashboards
  • Manual Universal Tests -- no
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review August 17, 2022 10:39
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 17, 2022 10:39
@jakubdyszkiewicz jakubdyszkiewicz changed the title fix(kuma-cp) collapsed grafana dashboards fix(kuma-cp): collapsed grafana dashboards Aug 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #4839 (636e558) into master (79a13d5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4839      +/-   ##
==========================================
- Coverage   46.47%   46.46%   -0.02%     
==========================================
  Files         690      690              
  Lines       47069    47069              
==========================================
- Hits        21876    21871       -5     
- Misses      23269    23273       +4     
- Partials     1924     1925       +1     
Impacted Files Coverage Δ
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (-5.13%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.77% <0.00%> (-1.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jakubdyszkiewicz
Copy link
Contributor Author

@Mergifyio backport release-1.8

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

backport release-1.8

✅ Backports have been created

@jakubdyszkiewicz jakubdyszkiewicz merged commit 878347d into kumahq:master Aug 17, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix-dashboards branch August 17, 2022 11:15
mergify bot pushed a commit that referenced this pull request Aug 17, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 878347d)
jakubdyszkiewicz pushed a commit that referenced this pull request Aug 17, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants