-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp): collapsed grafana dashboards #4839
Merged
jakubdyszkiewicz
merged 1 commit into
kumahq:master
from
jakubdyszkiewicz:fix-dashboards
Aug 17, 2022
Merged
fix(kuma-cp): collapsed grafana dashboards #4839
jakubdyszkiewicz
merged 1 commit into
kumahq:master
from
jakubdyszkiewicz:fix-dashboards
Aug 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
changed the title
fix(kuma-cp) collapsed grafana dashboards
fix(kuma-cp): collapsed grafana dashboards
Aug 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #4839 +/- ##
==========================================
- Coverage 46.47% 46.46% -0.02%
==========================================
Files 690 690
Lines 47069 47069
==========================================
- Hits 21876 21871 -5
- Misses 23269 23273 +4
- Partials 1924 1925 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lobkovilya
approved these changes
Aug 17, 2022
@Mergifyio backport release-1.8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 878347d)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change here #4727 was supposed to expand collapsed panels. However, for some reason a simple change
"collapsed": true
->"collapsed": false
does not fix that. The result is that all panels in this row are missing. In this PR:kuma-dataplane
andkuma-service-to-service
"collapsed": true
->"collapsed": false
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --