Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cni): retry loading images #4860

Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix(cni): retry loading images #4860

merged 1 commit into from
Aug 19, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 18, 2022 •
edited
Loading

Signed-off-by: slonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

@slonka
fix(cni): retry loading images
8f80003 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review August 18, 2022 21:13
@slonka slonka requested a review from a team as a code owner August 18, 2022 21:13
bartsmykla
bartsmykla approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@slonka slonka merged commit 12956ec into kumahq:master Aug 19, 2022
@slonka slonka deleted the fix/cni-taint-controller-test-failing-to-load-images branch August 19, 2022 07:16
@slonka
Copy link
Contributor Author

slonka commented Aug 19, 2022

@Mergifyio backport release-1.8

@mergify mergify bot mentioned this pull request Aug 19, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2022

backport release-1.8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 19, 2022
@slonka @mergify
fix(cni): retry loading images (#4860)
0c83f08 
Signed-off-by: slonka <slonka@users.noreply.github.com>
(cherry picked from commit 12956ec)
mergify bot added a commit that referenced this pull request Aug 25, 2022
@mergify @slonka
fix(cni): retry loading images (backport #4860) (#4861)
77ea61a 
fix(cni): retry loading images (#4860)

Signed-off-by: slonka <slonka@users.noreply.github.com>
(cherry picked from commit 12956ec)

Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonka @bartsmykla