-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatewayapi): add gateways.kuma.io/cross-mesh
annotation for GatewayAPI Gateways
#4911
Conversation
…wayAPI Gateways Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4911 +/- ##
==========================================
+ Coverage 46.68% 46.73% +0.05%
==========================================
Files 687 687
Lines 46656 46668 +12
==========================================
+ Hits 21781 21812 +31
+ Misses 22966 22950 -16
+ Partials 1909 1906 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Have you considered
? This way you can have listeners that are both cross-mesh and non-cross-mesh. |
Yeah. But it's the same as for MeshGateway, any service that can contact this Gateway will see an HTTP connection, not HTTPS. The fact that it's TLS is due to the underlying mesh. To me it feels off to have TLS/HTTPS as the protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remember about docs
@lahabana @johnharris85 WDYT? Any strong opinions? |
No strong opinions. |
I get your point @michaelbeaumont sounds like we should go the way you've implemented atm |
@michaelbeaumont Are we fine to merge it? |
@lukidzi Not yet, I want to try out another way using |
Closing this for now for the more Gateway API-like |
This proposes using the
gateways.kuma.io/cross-mesh
annotation to set all listeners to be cross-mesh for Gateway APIGateways
. This presumably covers most use cases. Users wanting to mix cross-mesh/non cross-mesh listeners can fall back onMeshGateway
.Closes #4397
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here?