Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removes update/gui command #4954

Merged
merged 1 commit into from
Sep 2, 2022
Merged

chore: removes update/gui command #4954

merged 1 commit into from
Sep 2, 2022

Conversation

kleinfreund
Copy link
Contributor

@kleinfreund kleinfreund commented Sep 1, 2022 •
edited by lukidzi
Loading

Removes the upgrade/gui command because we now have a GitHub Actions workflow that automatically create update PRs.

See kumahq/kuma-gui#367.

Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR -- Rework the way we depend on the gui from Kuma kuma-gui#367
  • Is the issue worked on linked? -- Yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? -- No.
  • Do you need to explicitly set a > Changelog: entry here? No.

Changelog: chore(gui): removes update/gui command

chore: removes update/gui command
fb06737 
Removes the upgrade/gui command because we now have a GitHub Actions workflow that automatically create update PRs.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
@kleinfreund kleinfreund added the kind/cleanup Cleanup/refactor an existing component/code label Sep 1, 2022
@kleinfreund kleinfreund self-assigned this Sep 1, 2022
@kleinfreund kleinfreund marked this pull request as ready for review September 1, 2022 10:45
@kleinfreund kleinfreund requested a review from a team as a code owner September 1, 2022 10:45
@kleinfreund kleinfreund mentioned this pull request Sep 1, 2022
Closed
lahabana
lahabana approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kleinfreund kleinfreund merged commit 6d7e499 into kumahq:master Sep 2, 2022
@kleinfreund kleinfreund removed their assignment Sep 2, 2022
@kleinfreund kleinfreund deleted the chore/remove-upgrade-gui-command branch September 2, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleinfreund @lahabana