Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kumactl): add option to install with experimental transparent proxy #4958

Merged
merged 4 commits into from
Sep 12, 2022
Merged

feat(kumactl): add option to install with experimental transparent proxy #4958

merged 4 commits into from
Sep 12, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 1, 2022 •
edited
Loading

Motivation for this was #4442 but it may be superfluous depending on when we want to switch to the new engine

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here?

@michaelbeaumont
feat: add option to install with experimental transparent proxy
2ac7772 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test: update for new config value
dd890dc 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 2, 2022 14:06
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 2, 2022 14:06
@michaelbeaumont
refactor(transparentproxy): use GetEnabledWithDefault
062cc96 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge remote-tracking branch 'origin/master' into feat/tp_v2
7ef89cf 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 0782061 into master Sep 12, 2022
@michaelbeaumont michaelbeaumont deleted the feat/tp_v2 branch September 12, 2022 08:21
@lukidzi lukidzi changed the title feat: add option to install with experimental transparent proxy feat(kumactl): add option to install with experimental transparent proxy Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbeaumont @lahabana @jakubdyszkiewicz