Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp): improve test xds client #4976

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Test XDS client currently was broken, because it was used a long time ago when we were on API V2.
I updated it to API V3. It's helpful in CP benchmarking without spawning thousands of Envoys.

On top of that, it does not present a realistic scenario.
Every DP had 10 inbounds and 10 outbound to every service. It means that with 2000 DPP every service has 2000 endpoints. In the real world, 1 DP has 1-2 inbounds and ~3-5 outbounds (with reachable services). I adjusted the code so you can decide how many inbounds and outbound a single DP has.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here?

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 7, 2022 09:37
…-xds-client

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

mk/run.mk Outdated Show resolved Hide resolved
tools/xds-client/main.go Outdated Show resolved Hide resolved
…-xds-client

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 66f0648 into kumahq:master Sep 12, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/improve-mock-xds-client branch September 12, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants