Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fixed location of developer tools in DEVELOPER.md docs #4988

Merged
merged 3 commits into from
Sep 9, 2022
Merged

fix(docs): fixed location of developer tools in DEVELOPER.md docs #4988

merged 3 commits into from
Sep 9, 2022

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Sep 9, 2022

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here?

@Automaat Automaat requested a review from a team as a code owner September 9, 2022 11:58
@Automaat
fix(docs): fixed location of developer tools in DEVELOPER.md docs
7855af2 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat force-pushed the fix/developer_documentation branch from 091a7ec to 7855af2 Compare September 9, 2022 11:59
michaelbeaumont
michaelbeaumont approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DEVELOPER.md Outdated Show resolved Hide resolved
Automaat and others added 2 commits September 9, 2022 14:59
@Automaat
Merge branch 'master' into fix/developer_documentation
f6c70c0
@Automaat @michaelbeaumont
fix(docs): fixed typo in DEVELOPER.md
3caf9e3 
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@lahabana lahabana merged commit e26dc6d into kumahq:master Sep 9, 2022
@Automaat Automaat deleted the fix/developer_documentation branch September 9, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Automaat @lahabana @michaelbeaumont