fix(helm): use podAnnotations everywhere possible
#4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecated `annotations` everywhere in favour of `podAnnotations` - Add test to validate all `annotations` values - Add `cni.podAnnotations` - Add README for helm chart tests Fix kumahq#4935 Co-authored-by: Deepak Mohandas <deepak.mohandas@konghq.com> Signed-off-by: Charly Molter <charly.molter@konghq.com>
jakubdyszkiewicz
approved these changes
Sep 12, 2022
|
@jakubdyszkiewicz what's you opinion with backporting? |
|
@Mergifyio backport release-1.8 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
- Deprecated `annotations` everywhere in favour of `podAnnotations` - Add test to validate all `annotations` values - Add `cni.podAnnotations` - Add README for helm chart tests Fix #4935 Signed-off-by: Charly Molter <charly.molter@konghq.com> Co-authored-by: Deepak Mohandas <deepak.mohandas@konghq.com> (cherry picked from commit c5223c8) # Conflicts: # UPGRADE.md # app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.cni-experimental-enabled.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.global.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.overrides.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.registry.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.tproxy-ebpf-experimental-enabled.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml # app/kumactl/cmd/install/testdata/install-cp-helm/empty.golden.yaml # app/kumactl/cmd/install/testdata/install-cp-helm/fix4485.golden.yaml # app/kumactl/cmd/install/testdata/install-cp-helm/fix4496.golden.yaml
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotationseverywhere in favour ofpodAnnotationsannotationsvaluescni.podAnnotationsFix #4935
Co-authored-by: Deepak Mohandas deepak.mohandas@konghq.com
Signed-off-by: Charly Molter charly.molter@konghq.com
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here?