Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/lib/pq from 1.10.6 to 1.10.7 #4995

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 12, 2022

Bumps github.com/lib/pq from 1.10.6 to 1.10.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.10.6 to 1.10.7.
- [Release notes](https://github.com/lib/pq/releases)
- [Commits](lib/pq@v1.10.6...v1.10.7)

---
updated-dependencies:
- dependency-name: github.com/lib/pq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner September 12, 2022 15:04
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 12, 2022
@lahabana
Copy link
Contributor

Clearly something is broken/different here: https://app.circleci.com/pipelines/github/kumahq/kuma/16439/workflows/a62b3ccf-e83b-47a4-9597-689ae9ced2ae/jobs/222640/tests

I believe it's due to the new SNI support, either there's a regression introduced or what we do in tests is wrong. I didn't investigate more.

lahabana and others added 3 commits September 13, 2022 09:51
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Sep 14, 2022

It looks like with lib/pq#1088 they fixed a longstanding discrepancy between libpq and the go lib so that SNI is now enabled by default. I added a localhost SAN to our test TLS certs.

I feel like this could break some users' setups (like it broke ours)... But only if they don't set the right CN/SAN?

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 4cc7092 into master Sep 15, 2022
@michaelbeaumont michaelbeaumont deleted the dependabot/go_modules/github.com/lib/pq-1.10.7 branch September 15, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants