Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-init): use iptables-legacy in kuma-init #5040

Merged
merged 1 commit into from
Sep 21, 2022
Merged

chore(kuma-init): use iptables-legacy in kuma-init #5040

merged 1 commit into from
Sep 21, 2022

Conversation

bartsmykla
Copy link
Contributor

Ubuntu 22.04 comes with iptables 1.8.7 which in default (non legacy) mode appears to sometimes crash (tested on GKE), so we manually set the legacy (non iptables->nftables translation) mode

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here?

@bartsmykla
chore(kuma-init): use iptables-legacy in kuma-init
e92d0fc 
ubuntu 22.04 comes with iptables 1.8.7 which in default (non
legacy) mode appears to sometimes crash (tested on GKE), so
we manually set the legacy (non iptables->nftables translation)
mode

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner September 21, 2022 12:06
@bartsmykla bartsmykla enabled auto-merge (squash) September 21, 2022 12:07
@bartsmykla bartsmykla merged commit c1e86b7 into kumahq:master Sep 21, 2022
@bartsmykla bartsmykla deleted the chore/kuma-init-use-iptables-legacy branch September 21, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartsmykla @lukidzi