Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): added validation for backend name #5081

Merged
merged 1 commit into from
Sep 30, 2022
Merged

feat(kuma-cp): added validation for backend name #5081

merged 1 commit into from
Sep 30, 2022

Conversation

Automaat
Copy link
Contributor

Backend name for builtin CA should be lowercase and must be valid dns name. Because we are creating k8s secret from this name, which has strict naming rules.

Fix #5012

Signed-off-by: Marcin Skalski marcin.skalski@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat Automaat requested a review from a team as a code owner September 29, 2022 15:40
@Automaat Automaat changed the title feat(kuma-cp): added validation for backend name. feat(kuma-cp): added validation for backend name Sep 29, 2022
@Automaat
feat(kuma-cp): added validation for backend name
10641ec 
Backend name for builtin CA should be lowercase and must be valid dns name. Because we are creating k8s secret from this name, which has strict naming rules.

Fix kumahq#5012

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat force-pushed the feat/improve_mtls_backend_validation branch from 7377720 to 10641ec Compare September 29, 2022 15:46
@Automaat Automaat merged commit e7750c4 into kumahq:master Sep 30, 2022
@Automaat Automaat deleted the feat/improve_mtls_backend_validation branch September 30, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing validation of CA name
2 participants
@Automaat @jakubdyszkiewicz