Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service-insights): add external service in api #5119

Merged
merged 2 commits into from
Oct 10, 2022
Merged

feat(service-insights): add external service in api #5119

merged 2 commits into from
Oct 10, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Oct 7, 2022

  • also make vip port configurable
  • rewrite some tests to get rid of unecessary shared state and locks

Fix #5077

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • [] Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
feat(service-insights): add external service in api
3dc7855 
- also make vip port configurable
- rewrite some tests to get rid of unecessary shared state and locks

Fix kumahq#5077

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner October 7, 2022 13:38
@lahabana
Copy link
Contributor Author

lahabana commented Oct 7, 2022

@kleinfreund this is what you need for the service view I believe

@lahabana
Copy link
Contributor Author

lahabana commented Oct 7, 2022 •
edited
Loading

Anyone feel free to take over this PR to unblock @kleinfreund

@jakubdyszkiewicz
Copy link
Contributor

I'm taking over this PR

@kleinfreund
Copy link
Contributor

@jakubdyszkiewicz @lahabana Thanks for picking this up. I’ll have a look at this soon. 👍

@jakubdyszkiewicz
chore(*): react on changes to external services
93e8c84 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit a4e4bd7 into kumahq:master Oct 10, 2022
@lahabana lahabana deleted the serviceInsightWithExternal branch March 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enrich service-insights endpoint to include external services
3 participants
@lahabana @jakubdyszkiewicz @kleinfreund