Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: back-ports api base path fix #5341

Merged
merged 1 commit into from
Nov 21, 2022
Merged

chore: back-ports api base path fix #5341

merged 1 commit into from
Nov 21, 2022

Conversation

kleinfreund
Copy link
Contributor

Back-ports a fix for the API base path detection (kumahq/kuma-gui@4c56659) into release-2.x for the patch version release of Kuma 2.0.1.

Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com

Mode details

Creating kuma-2.0.1 with fix:

cd kuma-gui
git fetch origin
git switch master
git reset --hard f3dba73d4c264b094b6b351a8b44f2d5a0dc4ecb
git switch --create kuma-2.0.1
git cherry-pick 4c5665947bb033eea8f1b2e9c86a01d65569226f

Building distribution files:

cd kuma-gui
git switch kuma-2.0.1
yarn install
yarn run build

Preparing PR for Kuma:

cd kuma
git switch release-2.x
git pull
git switch --create chore/back-port-api-base-path-fix-for-2.0.1
rm -rf ~/kong/kuma/app/kuma-ui/pkg/resources/data && mkdir -p ~/kong/kuma/app/kuma-ui/pkg/resources/data && cp -r ~/kong/kuma-gui/dist/* ~/kong/kuma/app/kuma-ui/pkg/resources/data

Testing changes:

make dev/tools
make build
KUMA_DP_SERVER_AUTH_TYPE=none make run/universal/memory

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- No
  • [ ] The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • [ ] The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • [ ] Unit Tests --
  • [ ] E2E Tests --
  • [ ] Manual Universal Tests --
  • [ ] Manual Kubernetes Tests --
  • [ ] Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? -- No. This PR is the back port and no other branches need it.
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? No

Back-ports a fix for the API base path detection (kumahq/kuma-gui@4c56659) into `release-2.x` for the patch version release of Kuma 2.0.1.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
@kleinfreund kleinfreund requested a review from a team as a code owner November 18, 2022 09:07
@kleinfreund kleinfreund self-assigned this Nov 18, 2022
@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Nov 18, 2022
@lahabana lahabana merged commit b93ab6a into kumahq:release-2.0 Nov 21, 2022
@kleinfreund kleinfreund deleted the chore/back-port-api-base-path-fix-for-2.0.1 branch November 21, 2022 08:38
@kleinfreund kleinfreund removed their assignment Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants