Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): added configuration of plugins and its order #5472

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Dec 8, 2022

Added possibility to configure which plugins should be applied and their order. Not sure yet how to test it properly.

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- fix: Controllable plugin ordering #5441
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested review from a team, bartsmykla and lobkovilya and removed request for a team December 8, 2022 18:56
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! I guess one thing here is that disabled policies still have an API for resource which is a little strange. Also you should update the readme on the policy gen

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
Copy link
Contributor Author

lukidzi commented Dec 9, 2022

Looks cool! I guess one thing here is that disabled policies still have an API for resource which is a little strange. Also you should update the readme on the policy gen

Do you think we should filter on matching to dp/api and do not allow the creation of other policies? More like really disabling those plugins? It seems to be difficult because most of the API things we generate before and even if we do not load the plugin API is going to show specific configuration.

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you likely need to update wiht policies that were recently added

pkg/xds/server/v3/reconcile.go Outdated Show resolved Hide resolved
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit bbbd5c0 into kumahq:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controllable plugin ordering
4 participants