-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp): added configuration of plugins and its order #5472
Conversation
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool! I guess one thing here is that disabled policies still have an API for resource which is a little strange. Also you should update the readme on the policy gen
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Do you think we should filter on matching to dp/api and do not allow the creation of other policies? More like really disabling those plugins? It seems to be difficult because most of the API things we generate before and even if we do not load the plugin API is going to show specific configuration. |
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you likely need to update wiht policies that were recently added
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Added possibility to configure which plugins should be applied and their order. Not sure yet how to test it properly.
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?