Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): filtering of name prefix on K8S #5517

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix(kuma-cp): filtering of name prefix on K8S #5517

merged 1 commit into from
Dec 16, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

Fix for filtering name prefix

fix #5512

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
fix(kuma-cp): filtering of name prefix on K8S
2b263d4 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, bartsmykla and lobkovilya and removed request for a team December 16, 2022 11:47
@jakubdyszkiewicz jakubdyszkiewicz merged commit c4a5ffb into kumahq:master Dec 16, 2022
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot filter by tags and name on Kubernetes
2 participants
@jakubdyszkiewicz @lukidzi