Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): use no ssl image #5560

Merged
merged 6 commits into from
Jan 31, 2023
Merged

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Jan 3, 2023

now that no ssl images graduated from preview we can use them

Signed-off-by: slonka slonka@users.noreply.github.com

Changelog: fix(docker): use no ssl image

Checklist prior to review

  • Link to docs PR or issue -- don't think we have docs on this yet
  • Link to UI issue or PR -- not a UI issue
  • Is the issue worked on linked? -- issue was in enterprise project
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests -- no impact on tests
  • E2E Tests -- no impact on tests
  • Manual Universal Tests -- no impact on tests
  • Manual Kubernetes Tests -- no impact on tests
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
Copy link
Contributor

@slonka what's the future of this PR?

@slonka
Copy link
Contributor Author

slonka commented Jan 16, 2023

what's the future of this PR?

I've put it on hold since there was more important policy related work. I think I had to run CI again because something was flaky. Now that it's all green I see no reason not to merge it.

@slonka slonka marked this pull request as ready for review January 16, 2023 13:06
@slonka slonka requested review from a team, bartsmykla and lobkovilya and removed request for a team January 16, 2023 13:06
mk/docker.mk Show resolved Hide resolved
@slonka
Copy link
Contributor Author

slonka commented Jan 19, 2023

@lahabana - are you ok with merging this?

@slonka slonka requested a review from lahabana January 19, 2023 13:48
@slonka slonka changed the title feat(build): use no ssl image [WIP] feat(build): use no ssl image Jan 19, 2023
@lahabana
Copy link
Contributor

Yeah sorry for not being reactive here :)

@slonka slonka merged commit 3443c6a into kumahq:master Jan 31, 2023
@slonka slonka deleted the feat/use-non-openssl-image branch January 31, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants