-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): use no ssl image #5560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka what's the future of this PR? |
I've put it on hold since there was more important policy related work. I think I had to run CI again because something was flaky. Now that it's all green I see no reason not to merge it. |
slonka
requested review from
a team,
bartsmykla and
lobkovilya
and removed request for
a team
January 16, 2023 13:06
lahabana
reviewed
Jan 16, 2023
@lahabana - are you ok with merging this? |
slonka
changed the title
feat(build): use no ssl image [WIP]
feat(build): use no ssl image
Jan 19, 2023
bartsmykla
approved these changes
Jan 25, 2023
jakubdyszkiewicz
approved these changes
Jan 25, 2023
Yeah sorry for not being reactive here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that no ssl images graduated from preview we can use them
Signed-off-by: slonka slonka@users.noreply.github.com
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? -- no> Changelog:
entry here or add aci/
label to run fewer/more tests?