Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): always call 'CollectResponse' inside 'Eventually' #5596

Merged
merged 2 commits into from
Jan 9, 2023
Merged

test(e2e): always call 'CollectResponse' inside 'Eventually' #5596

merged 2 commits into from
Jan 9, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Jan 9, 2023 •
edited by lahabana
Loading

fail examples:

Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: skip

@lobkovilya
fix: always call 'CollectResponse' inside 'Eventually'
0cae3ea 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested review from a team, Automaat and bartsmykla and removed request for a team January 9, 2023 11:25
@lobkovilya lobkovilya enabled auto-merge (squash) January 9, 2023 11:27
@lobkovilya
fix: call assertion with 'Gomega' object
fb531a1 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit 3d2ed49 into kumahq:master Jan 9, 2023
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@lobkovilya @bartsmykla
fix: always call 'CollectResponse' inside 'Eventually' (kumahq#5596)
ed91703 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@lahabana lahabana changed the title fix: always call 'CollectResponse' inside 'Eventually' test(e2e): always call 'CollectResponse' inside 'Eventually' Jan 17, 2023
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobkovilya @bartsmykla