Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-server): contain matches on name and tags #5606

Merged
merged 1 commit into from
Jan 9, 2023
Merged

feat(api-server): contain matches on name and tags #5606

merged 1 commit into from
Jan 9, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 9, 2023

The api now takes ?name to filter on subset of the dpp name it also works on subset for tag value

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
feat(api-server): contain matches on name and tags
d22f769 
The api now takes `?name` to filter on subset of the dpp name
it also works on subset for tag value

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested review from a team, michaelbeaumont and lukidzi and removed request for a team January 9, 2023 13:12
michaelbeaumont
michaelbeaumont approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understood correctly the changes are that namePrefix is no longer needed because name works the same way and that both name and tags work together?

pkg/core/policy/dataplane_matcher.go Show resolved Hide resolved
@lahabana lahabana merged commit e532510 into kumahq:master Jan 9, 2023
@michaelbeaumont michaelbeaumont mentioned this pull request Jan 10, 2023
Merged
12 tasks
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@lahabana @bartsmykla
feat(api-server): contain matches on name and tags (kumahq#5606)
35df0ef 
The api now takes `?name` to filter on subset of the dpp name
it also works on subset for tag value

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
@lahabana lahabana deleted the renameFilters branch May 2, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @michaelbeaumont