Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust MeshCircuitBreaker with memo #5651

Merged
merged 4 commits into from
Jan 12, 2023
Merged

fix: adjust MeshCircuitBreaker with memo #5651

merged 4 commits into from
Jan 12, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Jan 11, 2023 •
edited by lahabana
Loading

  • adjust MeshCircuitBreaker to align with the memo
  • add unit tests for validation

Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshCircuitBreaker policy

@lobkovilya lobkovilya marked this pull request as ready for review January 11, 2023 18:17
@lobkovilya lobkovilya requested review from a team, lahabana and lukidzi and removed request for a team January 11, 2023 18:17
@lobkovilya lobkovilya merged commit 9ef5f9e into kumahq:master Jan 12, 2023
@lobkovilya lobkovilya deleted the fix/adjust-mcb-with-memo branch January 12, 2023 10:32
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@lobkovilya @bartsmykla
fix: adjust MeshCircuitBreaker with memo (kumahq#5651)
cb3064d 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lahabana lahabana Awaiting requested review from lahabana

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lobkovilya @michaelbeaumont @jakubdyszkiewicz