Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move env to test/framework to be able to reuse it #5680

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

lahabana
Copy link
Contributor

This will enable other projects to leverage the test framework more easily

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested review from a team, slonka and jakubdyszkiewicz and removed request for a team January 12, 2023 16:40
@lahabana lahabana enabled auto-merge (squash) January 13, 2023 13:46
This will enable other projects to leverage the test framework more easily

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
Copy link
Contributor Author

@jakubdyszkiewicz @slonka review please :) It's tricky to keep this up to date with master

Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For big PRs with mostly renaming / moving around like this, you can just mention if there is any new logic so that we don't have to look for it.

@lahabana lahabana merged commit d793c99 into kumahq:master Jan 16, 2023
@lahabana lahabana deleted the refactorEnv branch May 2, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants