Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(policy): use enum for format in mesh retry #5749

Merged
merged 8 commits into from
Jan 18, 2023
Merged

fix(policy): use enum for format in mesh retry #5749

merged 8 commits into from
Jan 18, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Jan 18, 2023 •
edited by lahabana
Loading

Checklist prior to review

Changelog: feat(policy): implement MeshRetry policy

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- closes Add kubebuilder annotaiton "enum" to MeshRetry #5706
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka slonka requested review from a team, Automaat and lukidzi and removed request for a team January 18, 2023 11:32
@slonka
chore: update golden files
5039c90 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@lahabana
Copy link
Contributor

This steps on #5747 :(

@slonka
Copy link
Contributor Author

slonka commented Jan 18, 2023

This steps on #5747 :(

I'll merge this after

slonka added 4 commits January 18, 2023 14:25
@slonka
chore: merge with master
c17279a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
chore: make check pass
befdaf4 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
chore: update golden files
403970a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
fix(policy): fix unit test
9f5ee8d 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka enabled auto-merge (squash) January 18, 2023 13:34
@slonka slonka merged commit 59d2ffe into kumahq:master Jan 18, 2023
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add kubebuilder annotaiton "enum" to MeshRetry
3 participants
@slonka @lahabana @lukidzi