fix(policies): use GatewayAPI style header modifier in all policies #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahabana
requested review from
a team,
slonka and
jakubdyszkiewicz
and removed request for
a team
lahabana
force-pushed
the
fix5712
branch
2 times, most recently
from
ca2b3b9 to
e1383a6
Compare
pkg/plugins/policies/meshhealthcheck/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
|
/format /golden_files |
MeshHealthCheck and MeshRateLimit didn't adopt the same style of headers. This is important for api coherency Fix kumahq#5712 Signed-off-by: Charly Molter <charly.molter@konghq.com>
- Ensure Pascal case for Type value - Add Present and Absent as types Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
@jakubdyszkiewicz updated with lower case headers |
Signed-off-by: Charly Molter <charly.molter@konghq.com>
jakubdyszkiewicz
approved these changes
Jan 20, 2023
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MeshHealthCheck and MeshRateLimit didn't adopt the same style of headers.
Update MeshRetry to ensure Pascal case for Type value and add Present and Absent as types.
This is important for api coherency.
Fix #5712
Signed-off-by: Charly Molter charly.molter@konghq.com
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?