Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): make it possbile to install universal cp on k8s #5913

Merged
merged 18 commits into from
Feb 6, 2023
Merged

feat(helm): make it possbile to install universal cp on k8s #5913

merged 18 commits into from
Feb 6, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Feb 3, 2023 •
edited
Loading

closes #5907

Signed-off-by: slonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue -- Document new universal on k8s mode kuma-website#1231
  • Link to UI issue or PR -- not UI issue
  • Is the issue worked on linked? -- yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests -- we'll test it in MinK
  • Do you need to update UPGRADE.md? -- no need
  • Does it need to be backported according to the backporting policy? -- no need
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka
feat(helm): make it possbile to install universal cp on k8s
76fefdd 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): review suggestions
ebcdba0 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
Copy link
Contributor Author

slonka commented Feb 3, 2023

/format

@github-actions
fix(ci): format files
c5f8a12 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@slonka
Copy link
Contributor Author

slonka commented Feb 3, 2023

/golden_files

github-actions bot and others added 6 commits February 3, 2023 18:58
@github-actions
fix(ci): format files
93833ab 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@slonka
feat(helm): cp starts
923de6c 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): test passes
c2f131a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): make check passes
e0a2b06 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): move extracting token from response to common file
197b001 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): make check passes
b442b97 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review February 6, 2023 11:25
@slonka slonka requested review from a team, michaelbeaumont and jakubdyszkiewicz and removed request for a team February 6, 2023 11:25
jakubdyszkiewicz
jakubdyszkiewicz reviewed Feb 6, 2023
View reviewed changes
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go Outdated Show resolved Hide resolved
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go Outdated Show resolved Hide resolved
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go Show resolved Hide resolved
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go Outdated Show resolved Hide resolved
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go Outdated Show resolved Hide resolved
test/framework/deployments/postgres/kubernetes.go Outdated Show resolved Hide resolved
test/framework/controlplane.go Outdated Show resolved Hide resolved
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go Outdated Show resolved Hide resolved
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go Show resolved Hide resolved
slonka added 3 commits February 6, 2023 13:59
@slonka
feat(helm): review suggestions
929ec65 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): check if mesh is synced to zone
b8bc516 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): make wait
be4fa6e 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka changed the title feat(helm): make it possbile to install universal cp on k8s [WIP] feat(helm): make it possbile to install universal cp on k8s Feb 6, 2023
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 6, 2023
slonka added 4 commits February 6, 2023 15:45
@slonka
feat(helm): last review suggestions
f89a055 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): make check pass
94313df 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): fix deployment removal
b15ea29 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
Merge branch 'master' into universal-cp-on-k8s
2f04254
slonka added 2 commits February 6, 2023 18:07
@slonka
feat(helm): remove deployment removal since it seem flaky
4669b76 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(helm): fix wait pods available
3cd349b 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka merged commit 33b69bf into kumahq:master Feb 6, 2023
@slonka slonka deleted the universal-cp-on-k8s branch February 6, 2023 21:01
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ability to install universal control-plane on Kubernetes
3 participants
@slonka @lahabana @jakubdyszkiewicz