Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meshhttproute): add path modifier to redirect #5918

Merged
merged 5 commits into from
Feb 7, 2023
Merged

feat(meshhttproute): add path modifier to redirect #5918

merged 5 commits into from
Feb 7, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Feb 6, 2023 •
edited by lahabana
Loading

Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com

Changelog: feat(MeshHTTPRoute): add path modifier to redirect

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- Fix MeshHTTPRoute redirect: path modifier #5795
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lobkovilya
feat(meshhttproute): add 'path' to redirect
ddd3812 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested review from a team, michaelbeaumont and slonka and removed request for a team February 6, 2023 11:27
@lobkovilya
feat(meshhttproute): dedup code
efdbbef 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
slonka
slonka approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks, overall good!

pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go Outdated Show resolved Hide resolved
@lobkovilya @slonka
Apply suggestions from code review
e396ffe 
Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
@lobkovilya
Copy link
Contributor Author

/format

@lobkovilya
Copy link
Contributor Author

/golden_files

@github-actions
fix(ci): format files
feb416f 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lobkovilya
Copy link
Contributor Author

/golden_files

@github-actions
fix(ci): format files
bd8b1f0 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lobkovilya lobkovilya merged commit 9de9882 into kumahq:master Feb 7, 2023
@lobkovilya lobkovilya deleted the feat/meshhttproute-redirect-path branch February 7, 2023 19:25
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshHTTPRoute redirect: path modifier
3 participants
@lobkovilya @michaelbeaumont @slonka