Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): dont specify a default type for extraSecrets #5932

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

wheelerlaw
Copy link
Contributor

Generally it is better to use objects/dicts over lists because the former can be used in the exact same way as the latter and the former adds the functionality of being able to specify which element by name.

Also, in Helm, lists are overridden completely when using subsequent values.yaml files. On the other hand, objects/dicts are merged, making it easier to create a base values.yaml and override it with values-{env}.yaml without having to copy/paste a lot of stuff.

See this StackOverflow question: https://stackoverflow.com/questions/59394422/helm-charts-with-multiple-lists-in-multiple-values-files

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@wheelerlaw wheelerlaw requested review from a team, michaelbeaumont and slonka and removed request for a team February 7, 2023 08:38
@wheelerlaw wheelerlaw force-pushed the fix/no-default-values-types branch from 16724ec to 23ddefa Compare February 7, 2023 08:39
Signed-off-by: slonka <slonka@users.noreply.github.com>
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@slonka slonka merged commit f2d1210 into kumahq:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants