fix(helm): dont specify a default type for extraSecrets #5932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally it is better to use objects/dicts over lists because the former can be used in the exact same way as the latter and the former adds the functionality of being able to specify which element by name.
Also, in Helm, lists are overridden completely when using subsequent values.yaml files. On the other hand, objects/dicts are merged, making it easier to create a base values.yaml and override it with values-{env}.yaml without having to copy/paste a lot of stuff.
See this StackOverflow question: https://stackoverflow.com/questions/59394422/helm-charts-with-multiple-lists-in-multiple-values-files
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?