Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kds): relax tls requirement #6145

Merged
merged 9 commits into from
Feb 28, 2023
Merged

feat(kds): relax tls requirement #6145

merged 9 commits into from
Feb 28, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Feb 27, 2023 •
edited
Loading

Checklist prior to review

Changelog: feat(kds): allow running non-tls KDS server

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Related: https://github.com/Kong/kong-mesh/issues/2394

@slonka
feat(kds): relax tls requirement
3f15eb2 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka self-assigned this Feb 27, 2023
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 27, 2023
slonka
slonka commented Feb 27, 2023
View reviewed changes
pkg/config/multizone/kds.go Outdated Show resolved Hide resolved
@slonka
feat(kds): remove fdescribe
b498605 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
Merge branch 'master' into relax-tls-requirement-on-kds
abba053
@slonka
feat(kds): make check pass
aa36874 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kds): update golden files
1bde7bc 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kds): fix type
9c187a3 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review February 27, 2023 16:20
@slonka slonka requested review from a team, Automaat and bartsmykla and removed request for a team February 27, 2023 16:20
jakubdyszkiewicz
jakubdyszkiewicz reviewed Feb 27, 2023
View reviewed changes
deployments/charts/kuma/templates/_helpers.tpl Outdated Show resolved Hide resolved
pkg/config/multizone/kds.go Outdated Show resolved Hide resolved
@slonka
feat(zone-sync): review adjustments
23fb96d 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka force-pushed the relax-tls-requirement-on-kds branch from 7178e21 to 23fb96d Compare February 28, 2023 11:23
@slonka
feat(zone-sync): tmp
dadeec3 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(zone-sync): make test pass
9b9dc05 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka enabled auto-merge (squash) February 28, 2023 13:00
@slonka slonka merged commit 8d12990 into kumahq:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lahabana lahabana lahabana approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees

@slonka slonka

Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slonka @lahabana @jakubdyszkiewicz @bartsmykla