Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): security contexts for ebpf cleanup hook #6235

Merged
merged 8 commits into from
Mar 8, 2023
Merged

fix(helm): security contexts for ebpf cleanup hook #6235

merged 8 commits into from
Mar 8, 2023

Conversation

bartsmykla
Copy link
Contributor

ebpf-cleanup hook needs write access to the root filesystem to clean ebpf programs

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@bartsmykla
fix(helm): security contexts for ebpf cleanup hook
bb44db0 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested review from a team, slonka and lukidzi and removed request for a team March 8, 2023 09:22
@bartsmykla bartsmykla enabled auto-merge (squash) March 8, 2023 09:24
@bartsmykla
Copy link
Contributor Author

/format

michaelbeaumont
michaelbeaumont reviewed Mar 8, 2023
View reviewed changes
deployments/charts/kuma/values.yaml Outdated Show resolved Hide resolved
deployments/charts/kuma/values.yaml Outdated Show resolved Hide resolved
github-actions bot and others added 5 commits March 8, 2023 09:53
@github-actions
fix(ci): format files
d9a9df4 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bartsmykla
chore: be explicit inside security contexts
6ab7784 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@michaelbeaumont @bartsmykla
chore(deps): bump coredns from 1.10.0 to 1.10.1 (kumahq#6227)
b3e3001 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@bartsmykla
chore: make format results
e2396b2 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
Merge remote-tracking branch 'upstream/master' into fix/security-cont…
648aa0a 
…exts-for-ebpf-cleanup-hook
michaelbeaumont
michaelbeaumont approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deployments/charts/kuma/values.yaml Show resolved Hide resolved
@bartsmykla
chore: add more explicit comment about ebpfCleanup
dede69f 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
chore: update golden files
b6ecffe 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla merged commit f82a817 into kumahq:master Mar 8, 2023
@bartsmykla bartsmykla deleted the fix/security-contexts-for-ebpf-cleanup-hook branch March 8, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartsmykla @michaelbeaumont @slonka