Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): fix postgres client cert setup #6335

Merged
merged 16 commits into from
Mar 23, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Mar 23, 2023

Postgres CertPath and KeyPath are only required when the server requires authentication. This PR fixes the description and splits root ca bundle and key/cert secrets.

Changelog: fix(helm): postgres client cert setup

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

slonka added 4 commits March 23, 2023 13:02
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka requested review from a team, jakubdyszkiewicz and Automaat and removed request for a team March 23, 2023 12:33
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as draft March 23, 2023 12:44
slonka added 2 commits March 23, 2023 13:52
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review March 23, 2023 13:04
slonka added 2 commits March 23, 2023 14:06
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka added 3 commits March 23, 2023 14:13
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka requested a review from jakubdyszkiewicz March 23, 2023 14:07
slonka added 4 commits March 23, 2023 16:06
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka enabled auto-merge (squash) March 23, 2023 15:59
@slonka slonka merged commit 6308d9f into kumahq:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants