Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): update deps lock #6449

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Apr 3, 2023

You can notice that https://app.circleci.com/pipelines/github/kumahq/kuma/21067/workflows/2a43bae8-0197-4ee6-91ed-9983f7b4e1d3/jobs/375351 when building a cache key has different values:

when restoring the key:

Found a cache from build 369845 at vm-arm64_go.mod_Ti4qE0iaWKtkwqn+YlWM7QVJg2q0sn8UkspXwyovIlo=_qOuXTDhAQK7NRmQyqVNT3gzZa_U7zbOPMD3SL9cVK20=_x5iJMSyu47WcYOAagtkp5Ddbk0I6JwmYwbpsgPvojj4=

but when saving a key the value is different:

Skipping cache generation, cache already exists for key: vm-arm64_go.mod_Ti4qE0iaWKtkwqn+YlWM7QVJg2q0sn8UkspXwyovIlo=_x4tV6Rec00TCm4x3y2+QCrsQFo2GRCqTLqTzZgWecUo=_x5iJMSyu47WcYOAagtkp5Ddbk0I6JwmYwbpsgPvojj4=

When we introduce any change in circleci ci config, go.mod we might hit the issue with the wrong key. The dependency lock key has changed so I regenerated it.

Why checksum isn't correct?

Because of this change #6421, it touches dev.mk which since the introduction of versioned dev/tools takes dev.mk to calculate the checksum.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested review from a team, bartsmykla and lobkovilya and removed request for a team April 3, 2023 14:44
@lukidzi lukidzi changed the title chore(ci): update deps lock chore(build): update deps lock Apr 3, 2023
@lahabana lahabana merged commit d025f74 into kumahq:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants