Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(policy): matcher with same key not the same value #6460

Merged
merged 2 commits into from
Apr 5, 2023
Merged

fix(policy): matcher with same key not the same value #6460

merged 2 commits into from
Apr 5, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Apr 4, 2023 •
edited by slonka
Loading

Fix #6426

Changelog: fix(policy): merging of policies results in not applying policy on some outbounds

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
fix(policies): matcher with same key not the same value
2583417 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, michaelbeaumont, lukidzi and lobkovilya and removed request for a team April 4, 2023 09:53
@jakubdyszkiewicz
Copy link
Contributor Author

@Mergifyio backport release-2.1 release-2.0

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023 •
edited
Loading

backport release-2.1 release-2.0

✅ Backports have been created

@jakubdyszkiewicz jakubdyszkiewicz changed the title fix(policies): matcher with same key not the same value fix(policy): matcher with same key not the same value Apr 4, 2023
lobkovilya
lobkovilya reviewed Apr 4, 2023
View reviewed changes
pkg/core/xds/rules.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz
fix(policy): change condition
09ce068 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@slonka slonka merged commit 0e3ca75 into kumahq:master Apr 5, 2023
mergify bot pushed a commit that referenced this pull request Apr 5, 2023
@jakubdyszkiewicz @mergify
fix(policy): matcher with same key not the same value (#6460)
8effde6 
* fix(policies): matcher with same key not the same value

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 0e3ca75)
mergify bot pushed a commit that referenced this pull request Apr 5, 2023
@jakubdyszkiewicz @mergify
fix(policy): matcher with same key not the same value (#6460)
739a67c 
* fix(policies): matcher with same key not the same value

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 0e3ca75)
This was referenced Apr 5, 2023
Merged
Merged
slonka pushed a commit that referenced this pull request Apr 5, 2023
@mergify @jakubdyszkiewicz
fix(policy): matcher with same key not the same value (backport #6460) (
5aec871 
#6466)

fix(policy): matcher with same key not the same value (#6460)

* fix(policies): matcher with same key not the same value

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 0e3ca75)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
slonka pushed a commit that referenced this pull request Apr 5, 2023
@mergify @jakubdyszkiewicz
fix(policy): matcher with same key not the same value (backport #6460) (
16c62df 
#6467)

fix(policy): matcher with same key not the same value (#6460)

* fix(policies): matcher with same key not the same value

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 0e3ca75)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@lobkovilya lobkovilya lobkovilya approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merging of policies results in not applying policy on some outbound
4 participants
@jakubdyszkiewicz @lobkovilya @lukidzi @slonka